feat: CRL cache

revocation/crl/fetcher.go

@@ -51,8 +51,8 @@
 	// If Cache is nil, no cache is used.
 	Cache Cache
 
-	// DiscardCacheError specifies whether to discard the cache on error.
-	DiscardCacheError bool
+	// DiscardCacheFailure specifies whether to discard any error on cache.
+	DiscardCacheFailure bool
 
 	httpClient *http.Client
 }
@@ -86,9 +86,8 @@
 			if !nextUpdate.IsZero() && !time.Now().After(nextUpdate) {
 				return bundle, nil
 			}
-		}
-		if err != nil && !f.DiscardCacheError {
+		} else if !errors.Is(err, ErrCacheMiss) && !f.DiscardCacheFailure {
 			return nil, fmt.Errorf("failed to retrieve CRL from cache: %w", err)
 		}
 	}
 
@@ -99,8 +98,8 @@
 
 	if f.Cache != nil {
 		err = f.Cache.Set(ctx, url, bundle)
-		if err != nil && !f.DiscardCacheError {
+		if err != nil && !f.DiscardCacheFailure {
 			return nil, fmt.Errorf("failed to store CRL to cache: %w", err)
 		}
 	}
 

revocation/crl/fetcher_test.go

@@ -140,7 +140,7 @@ func TestFetch(t *testing.T) {
 			t.Errorf("NewHTTPFetcher() error = %v, want nil", err)
 		}
 		f.Cache = c
-		f.DiscardCacheError = true
+		f.DiscardCacheFailure = false
 		bundle, err := f.Fetch(context.Background(), uncachedURL)
 		if err != nil {
 			t.Errorf("Fetcher.Fetch() error = %v, want nil", err)
@@ -183,7 +183,7 @@ func TestFetch(t *testing.T) {
 			t.Errorf("NewHTTPFetcher() error = %v, want nil", err)
 		}
 		f.Cache = c
-		f.DiscardCacheError = true
+		f.DiscardCacheFailure = true
 		bundle, err = f.Fetch(context.Background(), expiredCRLURL)
 		if err != nil {
 			t.Errorf("Fetcher.Fetch() error = %v, want nil", err)
@@ -220,7 +220,7 @@ func TestFetch(t *testing.T) {
 			t.Errorf("NewHTTPFetcher() error = %v, want nil", err)
 		}
 		f.Cache = c
-		f.DiscardCacheError = true
+		f.DiscardCacheFailure = true
 		_, err = f.Fetch(context.Background(), uncachedURL)
 		if !strings.Contains(err.Error(), "delta CRL is not supported") {
 			t.Errorf("Fetcher.Fetch() error = %v, want delta CRL is not supported", err)
@@ -237,7 +237,7 @@ func TestFetch(t *testing.T) {
 			t.Errorf("NewHTTPFetcher() error = %v, want nil", err)
 		}
 		f.Cache = c
-		f.DiscardCacheError = true
+		f.DiscardCacheFailure = true
 		bundle, err = f.Fetch(context.Background(), exampleURL)
 		if err != nil {
 			t.Errorf("Fetcher.Fetch() error = %v, want nil", err)

revocation/internal/crl/crl_test.go

@@ -127,7 +127,7 @@ func TestCertCheckStatus(t *testing.T) {
 			t.Fatal(err)
 		}
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})
@@ -167,7 +167,7 @@ func TestCertCheckStatus(t *testing.T) {
 		}
 
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})
@@ -194,7 +194,7 @@ func TestCertCheckStatus(t *testing.T) {
 			t.Fatal(err)
 		}
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})
@@ -226,7 +226,7 @@ func TestCertCheckStatus(t *testing.T) {
 			t.Fatal(err)
 		}
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})
@@ -268,7 +268,7 @@ func TestCertCheckStatus(t *testing.T) {
 			t.Fatal(err)
 		}
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})
@@ -290,7 +290,7 @@ func TestCertCheckStatus(t *testing.T) {
 			t.Fatal(err)
 		}
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})
@@ -320,7 +320,7 @@ func TestCertCheckStatus(t *testing.T) {
 			t.Fatal(err)
 		}
 		fetcher.Cache = memoryCache
-		fetcher.DiscardCacheError = true
+		fetcher.DiscardCacheFailure = true
 		r := CertCheckStatus(context.Background(), chain[0].Cert, issuerCert, CertCheckStatusOptions{
 			Fetcher: fetcher,
 		})