Update Go to 1.14.1 #1543
Merged
Update Go to 1.14.1 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expcept in cross build, where we do not have a base image yet. Signed-off-by: Justin Cormack <[email protected]>
Signed-off-by: Justin Cormack <[email protected]>
Signed-off-by: Justin Cormack <[email protected]>
|
cc @HuKeping this is blocking some of the other PRs. I want to do a release soon with all the updates. |
HuKeping
approved these changes
Apr 2, 2020
| @@ -393,7 +393,7 @@ func TestNetworkError(t *testing.T) { | |||
| Err: errors.New("abc%3Adef%3Aghi"), | |||
| } | |||
| networkErr := NetworkError{Wrapped: err} | |||
| require.Equal(t, http.MethodGet+" https://auth.docker.io: abc:def:ghi", networkErr.Error()) | |||
| require.Equal(t, http.MethodGet+" \"https://auth.docker.io\": abc:def:ghi", networkErr.Error()) | |||
There was a problem hiding this comment.
wondering why success in the past?
There was a problem hiding this comment.
Yeah these were weird it looks like the error message printing changed in Go 1.14, I mean checking exact error messages is always risky.
This was referenced Apr 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except in cross build, where we do not have a base image yet.
Signed-off-by: Justin Cormack [email protected]