remove redundant check

not-napoleon · Jan 31, 2024 · f9b1629 · f9b1629
1 parent a548242
commit f9b1629
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/...icsearch/xpack/esql/expression/predicate/operator/arithmetic/EsqlArithmeticOperation.java b/...icsearch/xpack/esql/expression/predicate/operator/arithmetic/EsqlArithmeticOperation.java
@@ -134,12 +134,7 @@ protected TypeResolution checkCompatibility() {
             || (leftType == UNSIGNED_LONG && (false == (rightType == UNSIGNED_LONG || rightType == DataTypes.NULL)))) {
             return new TypeResolution(formatIncompatibleTypesMessage(symbol(), leftType, rightType));
         }
-        // If the LHS is numeric, the RHS should be numeric or null
-        if (leftType.isNumeric()) {
-            if (false == (rightType.isNumeric() || DataTypes.isNull(rightType))) {
-                return new TypeResolution(formatIncompatibleTypesMessage(symbol(), leftType, rightType));
-            }
-        }
+
         // at this point, left should be null, and right should be null or numeric.
         return TypeResolution.TYPE_RESOLVED;
     }