Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrei Stefan <[email protected]>
  • Loading branch information
not-napoleon and astefan authored Jan 31, 2024
1 parent 8cebe89 commit 0f7c111
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ protected TypeResolution checkCompatibility() {
// This checks that unsigned longs should only be compatible with other unsigned longs
DataType leftType = left().dataType();
DataType rightType = right().dataType();
if ((rightType == DataTypes.UNSIGNED_LONG && (false == (leftType == UNSIGNED_LONG || leftType == DataTypes.NULL)))
|| (leftType == DataTypes.UNSIGNED_LONG && (false == (rightType == UNSIGNED_LONG || rightType == DataTypes.NULL)))) {
if ((rightType == UNSIGNED_LONG && (false == (leftType == UNSIGNED_LONG || leftType == DataTypes.NULL)))
|| (leftType == UNSIGNED_LONG && (false == (rightType == UNSIGNED_LONG || rightType == DataTypes.NULL)))) {
return new TypeResolution(formatIncombatibleTypesMessage(symbol(), leftType.typeName(), rightType.typeName()));
}
// If the LHS is numeric, the RHS should be numeric or null
Expand Down

0 comments on commit 0f7c111

Please sign in to comment.