Seperate texture from the mesh object #656
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally need a set of vertices and indices that update very irregularly (never) but a texture that updates every frame. The vertices and indices copying every frame is not ideal, and I haven't seen many libraries coupling them like this. This proposal is a lot cleaner in my codebase at the very least, because I can use a borrow for a permanent "mesh" object and a borrow for a new texture object. No copying the texture into the mesh, which prevents me from needing to re-make the mesh every frame, which prevents me from needing to do a clone on my vertices and indices every frame.
Profiling wise in my application it wasn't such a big deal, but every little clone does matter.