Print new hash on stdout on success #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's currently possible to check the new value of HEAD, it becomes an issue if support for converting non-HEAD commits (whether on a ref or raw OIDs) becomes an option. While looking up the new commit by prefix might be possible it's annoying (even more so on lucky-commit where every commit is luckified).
masklinn
force-pushed
the
print-hash-on-success
branch
from
dc47c96
to
4c06132
Compare
|
CI failure should be fixed, implicit |
|
IMO, this isn't too useful anymore since #29 is closed. Thanks anyway for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's currently possible to check the new value of HEAD, it becomes an issue with #29. While looking up the new commit by prefix might be possible it's annoying. And it becomes very difficult when rewriting on a oid as then the entire repository has to be looked up (since the new commit is "detached")