-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change kind of community post from 1 to 72 #847
Conversation
Duplicated from here: #753 |
ACK, makes more sense than |
I think it makes sense to separate community posts from the common post event. however there are a few things that would need clarification. What kind should replies be? should they still be kind 1 and follow NIP-10? What about other event types? the way NIP-72 is written it make no mention of restrictions on event types that can be posted to a community (it only uses kind 1 as an example) @vitorpamplona #753 seems to be about community exclusive posts in addition to kind 1. this is similar but I think its more about not cluttering up the "main" kind 1 feed of other apps with community posts. |
Yep, but many clients already have a specific kind for exclusive posts. So, I would just use that kind instead of the 11. And then remove the possibility for Kind 1s to be attached to communities. |
Sorry I'm out of the loop, but what is kind 11? I don't see it mentioned in the other PR or this one. |
Sorry, kind 72 (there was another issue that wanted to use kind 11 for exclusive posts). My point is that |
Agreed, whether we use |
This is a breaking change and we will all die, but hopefully it is minor enough that implementors can switch easily. And there are few enough implementations that it should be doable.
Also implementations can keep reading 1 and 72 simultaneously while creating just 72 from now on, maybe?
The thing is that having different kinds for different purposes is generally better.