-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cursors): Use data-uris for cursors #266
Conversation
I've switched us from using `file-loader` to `url-loader`. This will automatically convert local URL imports to data URIs, which means the framework no longer needs to load them from a remote URL. #207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It's cool 🎉 If you don't use
|
I found the cause of But I can't push it to GitHub now 😭
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
LGTM
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I've switched us from using
file-loader
tourl-loader
. This will automatically convert local URLimports to data URIs, which means the framework no longer needs to load them from a remote URL.
fix #207