Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default db_schema to 'public' #18

Closed
wants to merge 1 commit into from
Closed

default db_schema to 'public' #18

wants to merge 1 commit into from

Conversation

shaibruhis
Copy link

As stated on Postgres's website, the default schema name is "public".

In the previous sections we created tables without specifying any schema names. By default such tables (and other objects) are automatically put into a schema named “public”.

@shaibruhis
Copy link
Author

@nossrannug not sure if you saw this or not :)

@nossrannug
Copy link
Owner

Hey @shaibruhis , things for the PR. I'll take a look at this tomorrow. I'm hoping to release a new version of feast-postgres then to support feast 0.19 and I might include this. Giving it some thought because it would be a breaking change for everyone that is using the default value

@shaibruhis
Copy link
Author

I do think it makes more sense to have it default to public but totally understand the concern for backward compatability!

Hoping it makes it in but no worries if not :)

@shaibruhis
Copy link
Author

shaibruhis commented Mar 16, 2022

@nossrannug, curious if you've had any more thoughts here or if I should close it out?

@nossrannug
Copy link
Owner

I won't be making any more changes to this repo since I'm working on moving the postgres functionality to Feast feast-dev/feast#2401

You can add a comment to the PR and we can get feedback from the people at Feast on what they think :)

@shaibruhis
Copy link
Author

Awesome! Congrats on merging it and looking forward to using it in Feast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants