Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👌 IMPROVE: apply P01-w01 feedback #1

Merged
merged 7 commits into from
Oct 12, 2022
Merged

👌 IMPROVE: apply P01-w01 feedback #1

merged 7 commits into from
Oct 12, 2022

Conversation

MrCordeiro
Copy link
Contributor

@MrCordeiro MrCordeiro commented Oct 3, 2022 •
edited
Loading

Applied collected feedback from Pod 01, weeks 01 and 02

  1. Break the first unit into 2 weeks, leaving a bit of Uncle Bob into each one
  2. Move "Smelly code" to the top position in the unit so students are aware of the problems of bad code before Uncle Bob throws the solution.
  3. Replace the Type Hint article with a "Tech with Tim" video
  4. Split assignment to its own week

@MrCordeiro MrCordeiro self-assigned this Oct 3, 2022
@MrCordeiro MrCordeiro requested a review from d4c0r1-nos October 7, 2022 16:27
@MrCordeiro MrCordeiro added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 7, 2022
@MrCordeiro MrCordeiro mentioned this pull request Oct 10, 2022
Merged
d4c0r1-nos
d4c0r1-nos approved these changes Oct 12, 2022
View reviewed changes
Copy link

@d4c0r1-nos d4c0r1-nos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gr8 job!

assignments/assignment_1/README.md
@@ -33,11 +46,14 @@ For this refactoring section, we have 3 activities:

Now, let's create a CI pipeline for this project. We will use GitHub Actions for this.

1. Create a new repo for this project.
1. Create a new repo for this project on GitHub.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to create a personal public repo, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@MrCordeiro MrCordeiro merged commit 3971fb6 into main Oct 12, 2022
@MrCordeiro MrCordeiro deleted the p01/w01/feedback branch October 12, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4c0r1-nos d4c0r1-nos d4c0r1-nos approved these changes

Assignees

@MrCordeiro MrCordeiro

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrCordeiro @d4c0r1-nos