Wrong split of repos

[bcdiaconu]

I found that there are some dir that contain - and space chars inside their names. So, my assumption is that, the name of such dir is splitted into 3 when read from CSV file. Therefore instead of one repo, it will be seen as 3 repos with one of them being -.

So, the solution, to my assumption, should be to change to better separators inside the CSV file (separators that are not elements of the union of the sets of accepted character for naming dirs or files for all targeted OSs)

So this is another bug altogether. I guess choosing this and creating a new issue with this new finding makes better sense

One sample of such a dir name is somedir - copy

[bcdiaconu]

The error balloon of Windows in the picture above should be of some help. Also the link below should explain how some chars are treated.

https://en.wikipedia.org/wiki/Filename#In_Windows

[nosarthur]

thanks, maybe a simple fix is to use , to separate the repo names in groups.csv, instead of

[nosarthur]

Could you try this change on your gita repo, then pip3 install -e . in the gita repo (or make install)? This will install your local version. I feel there is a good chance this already works

[bcdiaconu]

I will test this when going back to work. There I have the repos where this bug was revealed so I know where to look.

I remember of a game we used to play when we were kids. The rules were simple. We were a few kids and we were choosing a starting point (a kid) and a different end point (another kid). The kid chosen to start would think of an word and would whisper it into another one's ear (without anyone else hearing it). Than the one receiving the information would pass it to the next one in the same manner. This would go on untill the information reached the ending kid. The last rule was that the ending kid would say out loud what he received. Of course, because the information was not passed reliably, many times it would get mutated. This was an amusing game.

Keeping this game in mind, the approach where implementation is replicated by pictures is not reliable. Think that the one looking at pictures can overlook some detail or implements it in another location than where he was suppose to do it. Also the person adding the code in pictures might forget to snapshot some details. The result of such errors will invalidate a possible valid solution.

How I see it, is that the best approach is to create a fix/220 branch which can be pulled, which brings reliability and no "implementation" errors can occur.

[nosarthur]

that's a good point, see #221

[nosarthur]

@bcdiaconu Does this PR fix your problem?