-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for subsectioned Values #194
Conversation
This adds `@section` comments, which will be parsed into semantic section info for valueRows. This allows to generate sectioned Values Tables by adding the templates `chart.valuesSectionedSection` and `chart.valuesSectionedSectionHTML` and thereby keeping compatability with default Values Tables
These tests check if sections are recognised and values are grouped together, if sections still work with annotations (like `@default` or `@raw`), and if different sections still work and are grouped correctly
…ions This looks better, because we shouldn't create a table in a sorting function
@Nepo26 any chances of implementing this feature in the near future? Looks super helpful! |
Hi @klaudiagrz, It really seems promising, I just need to review it, but I'm with little time recently. I can't promise anything, however I'll try to focus some time in this weekend. |
Got some time now. I'm looking into it. |
Hey @Nepo26, did you manage to look at this PR yet? :) |
Hey @Haepaxlog I'm sorry for the slow response on this. I really like the idea here, and I've added some comments that I think would improve things slightly. Thanks so much for the contribution, if you make the couple changes I've proposed, happy to merge it. |
hey @norwoodj , could you please have a look at the changes? Thank you 🙇 |
Sorry for my slowness getting back to this. I've merged. Thank you very much for the very cool contribution |
This PR closes #193 by adding section info to necessary structs and also retrieving
this section mapping through
# @section -- [section name]
annotations.In order to keep compatibility with regular unsectioned
values.yaml
files, this means alsointroducing a separate Sections field to
chartTemplateData
, through which a templatesimilar to
valuesTableTemplate
calledvaluesTableSectionedTemplate
can be evoked to generatefiles similar to this:
or HTML data:
General
"config-volume"
"nginx-ingress-controller"
"18.0831"
"controller"
"stupidchess.jmn23.com"
"LoadBalancer"
Some Section
"nginx-ingress-config"
Special Attention
"nginx"
null
I'd be happy if this feature makes it in in some shape or form as I can see the need for documentation people to have it integrated into the tool :)