Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird circle curve issue #4298

Closed
luckychris opened this issue Aug 19, 2021 · 3 comments
Closed

weird circle curve issue #4298

luckychris opened this issue Aug 19, 2021 · 3 comments
Labels

Comments

@luckychris
Copy link

luckychris commented Aug 19, 2021

I have this node setup and got some strange results at certain n points:

image

image
image
Uploading image.png…

@portnov
Copy link
Collaborator

portnov commented Aug 21, 2021

It seems to be a numeric precision issue.
I've added more details to the error:

 Knot vector items are not all non-decreasing: u[28] = 6.283185307179587 > u[29] = 6.283185307179586

portnov added a commit that referenced this issue Aug 21, 2021
@Durman
Copy link
Collaborator

Durman commented Aug 22, 2021

I'm not sure that this message make understanding of the error better.))
It would be nice to add information into the documentation that this node expects not all possible values. It will decrease number of similar issues I think.

@portnov
Copy link
Collaborator

portnov commented Aug 22, 2021

For this particular node, I fixed generation of knotvector so that it is always valid.
But the error message is generated in the underlying module, where the knotvector can be passed from anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants