Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types #22

Merged
merged 21 commits into from
Oct 18, 2023
Merged

Add types #22

merged 21 commits into from
Oct 18, 2023

Conversation

cpkdevries
Copy link
Contributor

@cpkdevries cpkdevries commented Feb 14, 2023

Goal

  • Add explicit types to bundle.

@cpkdevries cpkdevries changed the title WIP: Add types Add types Feb 23, 2023
src/Grid/Action/MassAction.php Outdated Show resolved Hide resolved
src/Grid/Action/MassAction.php Outdated Show resolved Hide resolved
src/Grid/Action/MassAction.php Outdated Show resolved Hide resolved
src/Grid/Action/RowAction.php Outdated Show resolved Hide resolved
src/Grid/Action/RowAction.php Outdated Show resolved Hide resolved
src/Grid/Column/Column.php Outdated Show resolved Hide resolved
src/Grid/Column/DateTimeColumn.php Outdated Show resolved Hide resolved
src/Grid/Column/DateTimeColumn.php Outdated Show resolved Hide resolved
src/Twig/DataGridExtension.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@natewiebe13
Copy link
Contributor

Also I see tests are failing. Can you get them passing again?

@natewiebe13 natewiebe13 assigned cpkdevries and unassigned cpkdevries Apr 4, 2023
@cpkdevries
Copy link
Contributor Author

Also I see tests are failing. Can you get them passing again?

So, basically what happened

  • Bundle used to get services directly from the container (which is now deprecated)
  • I "fixed" by injecting services that were being retrieved from the container previously (one of which was doctrine)
  • I now see that we may have wanted to do this differently, as this adds a project dependency for doctrine (previously, both doctrine and mongo were dev dependencies with a suggest to add one or the other based on your needs. Because we just removed mongodb support here, I think it's fine to just move orm to dependencies and remove the suggest).

@cpkdevries cpkdevries assigned natewiebe13 and unassigned cpkdevries Apr 5, 2023
@cpkdevries cpkdevries merged commit 094783d into symfony-6-update Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants