Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core folder #90

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Add core folder #90

merged 3 commits into from
Aug 15, 2023

Conversation

mindplay-dk
Copy link
Contributor

Changes per #89

I left defer in parsers for now, since it does implement Parser<T>, and the inline documentation literally says it's a "special parser".

@vercel
Copy link

vercel bot commented Aug 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sigma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 2:24pm

mindplay-dk
mindplay-dk commented Aug 13, 2023
View reviewed changes
docs/docs/content/core/run.md Show resolved Hide resolved
src/parsers.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5868189721

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5847896556: 0.0%
Covered Lines: 265
Relevant Lines: 265
💛 - Coveralls

@norskeld norskeld added A-structure Area: Issues related to repository/code structure A-docs Area: Issues related to documentation labels Aug 13, 2023
@norskeld norskeld linked an issue Aug 13, 2023 that may be closed by this pull request
Docs: run and tryRun aren't parsers #89
Closed
@norskeld
Copy link
Owner

I left defer in parsers for now, since it does implement Parser<T>

Ah, yes, you are right. Overall LGTM!

@mindplay-dk mindplay-dk marked this pull request as ready for review August 15, 2023 14:24
@norskeld norskeld merged commit 8c2849d into norskeld:master Aug 15, 2023
@norskeld
Copy link
Owner

This PR is included in version 3.6.5.

@norskeld norskeld added the R-released Semantic Release: Success label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norskeld norskeld norskeld left review comments

Assignees
No one assigned
Labels
A-docs Area: Issues related to documentation A-structure Area: Issues related to repository/code structure R-released Semantic Release: Success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: run and tryRun aren't parsers
3 participants
@mindplay-dk @coveralls @norskeld