Add commit comment feature. (#40 - #43) #20
Conversation
| @@ -36,7 +37,10 @@ def napalm_configure( | |||
|
|
|||
| dry_run = task.is_dry_run(dry_run) | |||
| if not dry_run and diff: | |||
| device.commit_config() | |||
| if comment: | |||
There was a problem hiding this comment.
Based on napalm's documentation I think you should be able to just do the following:
...
comment: str = "",
...
if not dry_run and diff:
device.commit_config(message=comment)
There was a problem hiding this comment.
That is true, however i like to put that logic in there to see if a commit_message actually exists prior to sending it in.
| @@ -11,6 +11,7 @@ def napalm_configure( | |||
| filename: Optional[str] = None, | |||
| configuration: Optional[str] = None, | |||
| replace: bool = False, | |||
| comment: str = None, | |||
There was a problem hiding this comment.
maybe commit_message is a bit more descriptive argument name
|
Thanks for your contribution, I left a couple of very minor comments |
1 similar comment
|
Thanks for your contribution, I left a couple of very minor comments |
|
@dbarrosop absolutely fine with having it as |
Modified `commit` argument with `commit_message` and modified line 41 to reflect this.
|
I've added the slight recommendations to the parameter naming which i agree are a bit more descriptive. |
|
Thanks! |
|
Have a question. At what point would this change be made when using the |
|
@dbarrosop regarding my previous comment. I ask because when I install salt-nornir / nornir-salt it's taking the latest version via pip Thx in advance |
|
I will try to do a quick release tomorrow |
|
That might take longer than expected, somehow the CI broke and I don't have the cycles right now to fix it: If someone can help out with that it will certainly expedite the release. |
|
@dbarrosop it looks like it's related to the installation of pyzmq. As for the other failures it looks like it never finished off running Not sure if any of this helps you but that was from my quick glance at the failure of the pipeline. |
|
I took a quick look and I think the problem is the linter is running with Python 3.10 and for the pyzmq version 19.0.1 is no whl file on mypy for python 3.10 and pip downloads the source and tries to build it and GCC failes. I created an PR to update all the dependencies #22 |
|
@gcasella nornir_napalm 0.2.0 has been released |
This commit change is to add the comment functionality for pushing changes out to network devices.