Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for item variants #89

Open
ggttttggggtt opened this issue Aug 4, 2022 · 3 comments
Open

Improve support for item variants #89

ggttttggggtt opened this issue Aug 4, 2022 · 3 comments

Comments

@ggttttggggtt
Copy link

These vests don't appear in the search:

SWAT ballistic vest
security stab vest
police ballistic vest

@nornagon
Copy link
Owner

nornagon commented Aug 5, 2022

nornagon added a commit that referenced this issue Aug 5, 2022
@nornagon
Copy link
Owner

nornagon commented Aug 5, 2022

this is somewhat addressed by ea14459. variant items are now searchable by their names and ids, and will show up the "base" item in results. alternative names will be shown on the item screen.

i don't think i want to treat each variant item as a unique separate item in the results as that will unnecessarily blow up the search results. but i think this could use more work to be better:

  1. it should be possible to see the variant descriptions and ascii art, if present. perhaps some sort of selector that lets you choose between the different variants?
  2. when searching, if one of the variant names matches the query "better" than the base name, we should show that result instead. [done] (and maybe auto-select the searched-for variant when clicking the result?)
  3. probably links to the variant item id of the form /item/<variant_id> should work. maybe that's how the variant selector works, by changing the url?

nornagon added a commit that referenced this issue Aug 13, 2022
@nornagon nornagon changed the title Law enforcement vests are missing Improve support for variants Jun 12, 2023
@nornagon nornagon changed the title Improve support for variants Improve support for item variants Jun 12, 2023
@nornagon
Copy link
Owner

Updated the title of the issue to reflect the remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants