Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors not having a message property #45

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Fix errors not having a message property #45

merged 3 commits into from
Jan 7, 2024

Conversation

normartin
Copy link
Owner

@normartin normartin commented Oct 25, 2023 •
edited
Loading

Both RetryError and NotRetryableError now have a message property. Change should be backward compatible as it only adds an optional property.

@normartin normartin mentioned this pull request Oct 25, 2023
Closed
@coveralls
Copy link

coveralls commented Oct 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6644112417

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6015584939: 0.0%
Covered Lines: 78
Relevant Lines: 78
💛 - Coveralls

@normartin normartin mentioned this pull request Oct 25, 2023
Closed
@eugeneYWang
Copy link

@normartin Hi Maritin, it seems like the issue author is giving approval. Are you looking to merge this and include in a new release?

@normartin normartin marked this pull request as ready for review January 7, 2024 08:14
@normartin normartin merged commit 3599105 into master Jan 7, 2024
7 checks passed
@normartin normartin deleted the fix-error-message-property branch January 7, 2024 08:15
@normartin
Copy link
Owner Author

Thanks @eugeneYWang for reminding me of this. It is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@normartin @coveralls @eugeneYWang