Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme example's async example to use IIFE #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated readme example's async example to use IIFE #62

wants to merge 1 commit into from

Conversation

mattwelke
Copy link

@mattwelke mattwelke commented Mar 12, 2018

I notice the first example uses a series of statements (which would perform the action), but the second example, showcasing async/await syntax, uses a function definition instead. If someone ran the code examples, they would not do the same thing, especially if one extended the example with statements inside the if bodies.

I changed the second example to align with the first. Same style (semicolons, function instead of arrow function, etc), but the second example now also shows code that "does stuff".

@coveralls
Copy link

coveralls commented Mar 12, 2018

Coverage Status

Coverage remained the same at 92.308% when pulling 1f72eb1 on welkie:master into f3d4c79 on normalize:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants