fix: Issue 534 transformation tests failing on some platforms #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
The 3D Transformation utests were failing on Ubuntu Bionic with Eigen 3.3.4, in contrast to all other platforms tested with Eigen 3.4.
I added a non-zero epsilon precision value to Eigen's
isApprox
call for Rotation and Rotation+Scaling tests.My guess is the two versions of Eigen treat zero epsilon precision values differently; hence the tests weren't failing with 3.4.0.
Fixes #534
Changes and type of changes (quick overview):
isApprox
in failing Transformation utest.Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check README.md #Contributing
for local testing procedure using libpointmatcher-build-system)
PR creation related
base ref
branch is set to thedevelop
branch(the build-system won't be triggered otherwise)
develop
branch(the build-system will reject it otherwise)
PR description related
# <issue-id>
if changes are of typefix
feat
fix
docs
style
refactor
perf
test
build
ci
chore
revert
<type>!
see commit_msg_reference.md
in the repository root for details
Note for repository admins
Release PR related
push/merge
on the default branch (ie:master
)and the
release
branch.draft
mode until all the release reviewers are ready to push the release.release
->master
branch is created (not in draft mode),