Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch ModuleNotFoundError on cache retrieve #258

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

LucasGrugru
Copy link
Contributor

Catch ModuleNotFoundError for error cases due to pickle serialization of old classpath

Description

I propose a fix for the issue I wrote: #257

As for previous KeyError catching implementation, I don't know how to test it. Do you have any idea?

Catch ModuleNotFoundError for error cases due to pickle serialization of old classpath
Copy link
Collaborator

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you:)

@coveralls
Copy link

coveralls commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9347303039

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.182%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cachalot/monkey_patch.py 0 1 0.0%
Totals Coverage Status
Change from base Build 7485195242: 0.0%
Covered Lines: 702
Relevant Lines: 715

💛 - Coveralls

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit 60101f7 into noripyt:master Jun 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants