Correct problems with tests to get django-cachalot to work with 4.2 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated tests to account for the `BEGIN` and `COMMIT` query changes in Django 4.2 - Standardized django version comparisons in tests
|
thank you for this! Much appreciated! |
Andrew-Chen-Wang
added a commit
that referenced
this pull request
Jul 11, 2023
* Add Django 4.1-4.2 and Python 3.11 support (Fixes #228) * Increment version to 4.5.0 * Remove Python 2 and Django 2.2 code * Fix CI supported versions * Correct problems with tests (#234) * Fix simple error * Andrew wang/dj4.2 Improve assertNumQueries by filtering out transaction-related queries (#238) * Andrew wang/dj4.2 (#239) * Added a FilteredTransactionTestCase, updated tests. * Added more filtered tests * Removed Python <3.10 from the tox envlist for Django main. * Enhanced error message to include current database vendor of the connection for better easier troubleshooting. * Use python3.10 for GH workflows, fix postgres range issues in tests. * Check if psycopg3 is in use, if so, add psycopg3 types to CACHABLE_PARAM_TYPES. --------- Co-authored-by: Benedikt Willi <[email protected]> --------- Co-authored-by: Jack Linke <[email protected]> Co-authored-by: Jack Linke <[email protected]> Co-authored-by: Benedikt Willi <[email protected]> Co-authored-by: Benedikt Willi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to the changes @Andrew-Chen-Wang implemented, this additional work aims to correct the test issues his PR was experiencing.
BEGINandCOMMITquery changes in Django 4.2I have not been able to verify tests locally, but based this work on the tox output in CI. Once merged into noripyt:andrew-wang/dj4.2 and run through CI again, I will happily clean up any remaining minor issues.