Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Global Base Styles #60

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Theme Global Base Styles #60

merged 2 commits into from
Dec 4, 2018

Conversation

arcticicestudio
Copy link
Contributor

Associated epic: #51
Resolves #59

@arcticicestudio
Implement "background" and "font" CSS module styles
dc5f56b 
They will be initially used in the global theme styles implemented
in GH-53.

Associated epic: GH-51
GH-59
@arcticicestudio
Integrate basic font and background colors in global CSS theme styles
68a39cc 
This includes a `transition` for both attributes to ensure a smooth
theme mode transition.

Associated epic: GH-51
GH-59
@arcticicestudio arcticicestudio added this to the 0.2.0 milestone Dec 4, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 4, 2018
@codecov
Copy link

codecov bot commented Dec 4, 2018 •
edited
Loading

Codecov Report

Merging #60 into develop will increase coverage by 4.57%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
+ Coverage       74%   78.57%   +4.57%     
===========================================
  Files           15       17       +2     
  Lines           50       56       +6     
  Branches         9        9              
===========================================
+ Hits            37       44       +7     
+ Misses          10        9       -1     
  Partials         3        3
Flag Coverage Δ
#unit 78.57% <100%> (+4.57%) ⬆️
Impacted Files Coverage Δ
src/styles/theme/colors/index.js 100% <ø> (ø) ⬆️
src/styles/theme/colors/font.js 100% <100%> (ø)
src/styles/theme/colors/background.js 100% <100%> (ø)
src/styles/theme/globals.js 100% <100%> (ø) ⬆️
src/styles/theme/utils/themedMode.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86edb92...68a39cc. Read the comment docs.

@arcticicestudio arcticicestudio merged commit 2c545da into develop Dec 4, 2018
@arcticicestudio arcticicestudio deleted the feature/gh-59-theme-global-base-styles branch December 4, 2018 14:33
@arcticicestudio arcticicestudio removed their assignment Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-ui scope-maintainability scope-ux type-feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb