Update status codes and #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add status with the status string, raw access to chargerOpmode is now possible.
|
I think it looks good! Do you want to join us in the discord channel where we have a lot of activity? We are 4 main devs atm but are always looking for more |
|
Sure |
|
Here the channel https://discord.gg/3e6zxR |
|
Lets make them lowercase and then merge this and right after create a PR to easee_hass which bumps the major version and shows it is a breaking change. |
|
I haven't been diving into details in the code here so perhaps it is already taken care of, but please make sure that new, unknown integer codes are handled properly, e.g. mapped to "unknown_status_##". |
astrandb
added a commit
that referenced
this pull request
Oct 27, 2020
fondberg
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add status with the status string, raw access to chargerOpmode is now possible.
This will be a breaking change but i think the status codes are better, especially with the updated reason for no current as you get more info about that is happening.
I also wanted to not overwrite the chargerOpmode so this is still a int and status is the string.