-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean removal of entities #74
Conversation
For me, the binary_sensors did not get created directly after the update, I had to change the settings to remove one binary_sensor and add it again. Or that was what I did at least to make it work again. I also get an error when the equalizer status sensor is updated: Sorry I do not have time right now to dig deeper. |
@olalid I can't reproduce the issue with binary_sensor. Greatful if you can pinpoint when it happens. Unfortunately it is difficult do debug equalizer related problem when you haven't got one. |
Yes, I understand that it is difficult to understand with the limited info I provided. |
…into removal_of_entities
…into removal_of_entities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @astrandb
Problem solved. |
Hold on, I just discovered that the removal of equalizer sensors does not work for some reason. Investigating... |
Fix equalizer entity removal
I fixed the equalizer removal bugs and merged to this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@olalid I don't know what happened when you added your fix. Suddenly this PR contains some 15 commits from you that seem to be old and irrelevant here. The resulting code is OK but I suggest that you check so you base your changes on correct branch. @fondberg @tmjo I think this PR is as good as it gets for now. I should be squashed & merged. |
Yeah, I am not a git guru, so I messed up a bit I guess. |
Improved handling of the unselecting of entities and the following cleanup.
I cannot verify that it works for eq-sensors since I don't have access to an Equalizer.