Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalizer changes #71

Merged
merged 15 commits into from
Oct 20, 2020
Merged

Equalizer changes #71

merged 15 commits into from
Oct 20, 2020

Conversation

olalid
Copy link
Collaborator

@olalid olalid commented Oct 18, 2020

Separate equalizer sensor config from charger sensor config.
Add support for attribute rounding on equalizer sensors.
Remove decimals from Max/Dynamic current sensors.

@olalid
Copy link
Collaborator Author

olalid commented Oct 18, 2020

@tmjo there are a few new translations needed.

@astrandb
Copy link
Collaborator

OK with me.

I found a little spelling error - "Equalzier" - on two places in controller.py. It is not found during execution in my setup but the linter found it.

@tmjo
Copy link
Collaborator

tmjo commented Oct 19, 2020

Looks ok to me too. Committed updated nb translation. I also saw the spelling error that astrandb mentioned.

Copy link
Collaborator

@astrandb astrandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@olalid
Copy link
Collaborator Author

olalid commented Oct 19, 2020

OK with me.

I found a little spelling error - "Equalzier" - on two places in controller.py. It is not found during execution in my setup but the linter found it.

Fixed.

@fondberg fondberg merged commit dd1ed3e into nordicopen:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants