Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize status sensor #67

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Localize status sensor #67

merged 3 commits into from
Oct 18, 2020

Conversation

astrandb
Copy link
Collaborator

Sensor status can now be localized so "CHARGING" is "Charging" in english and "Laddar" in swedish. Bokmål remains to be fixed.

@tmjo
Copy link
Collaborator

tmjo commented Oct 16, 2020

Looks good. We should add the UNKNOWN which is actually ERROR, see my PR in pyeasee lib I can fix the nb file.

@tmjo
Copy link
Collaborator

tmjo commented Oct 16, 2020

If you don't mind, please just put in the nb as well. If not I can put it in later.

{
  "state": {
    "easee_status": {
      "STANDBY": "Ventemodus",
      "PAUSED": "Pause",
      "READY_TO_CHARGE": "Klar til lading",
      "CAR_CONNECTED": "Bil tilkoblet",
      "CHARGING": "Lader"
    }
  }
}

@fondberg
Copy link
Contributor

Will this mean automations no longer can use the english capitalised statuses?

@astrandb
Copy link
Collaborator Author

astrandb commented Oct 18, 2020

Translation is done in frontend. The internal representation of state should not be affected. Can be verified in Developer Tools.

@fondberg fondberg merged commit b41a1e1 into master Oct 18, 2020
@fondberg fondberg deleted the Status_i8n branch October 18, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants