Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the package.json exports and actually provide the typescript types #839

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented Nov 8, 2024

To test this you can do this:

  1. Run yarn build
  2. Go into a package
  3. Run node ../../scripts/prepack.js
  4. Run npx publint
  5. Verify its happy

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@MTRNord MTRNord requested a review from a team as a code owner November 8, 2024 11:16
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 377d8d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MTRNord
Copy link
Contributor Author

MTRNord commented Nov 8, 2024

Also a good read for this is https://github.com/frehner/modern-guide-to-packaging-js-library on which I based this.

@MTRNord MTRNord merged commit afd0417 into main Nov 8, 2024
4 checks passed
@MTRNord MTRNord deleted the nic/fix/NEO-1010 branch November 8, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants