Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the download_file widget action #759

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Aug 26, 2024

Implements usage of the download_file action of the Widget API.
See MSC4039 .

Also moves the UploadImagePage page to ImagePage since it now demos up- and download of content.

Needs matrix-org/matrix-react-sdk#12931

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: a1e0dea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@matrix-widget-toolkit/api Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is wrong, the upload happens 3 times every time i try it:
image

HarHarLinks
HarHarLinks previously approved these changes Aug 28, 2024
@HarHarLinks
Copy link
Contributor

test setup: matrix-org/matrix-widget-api#99 (comment)

@HarHarLinks
Copy link
Contributor

matrix-widget-api was merged and released as 0.9.0, matrix-react-sdk was merged and is slated for the next element-web release cycle (RC on 2024-09-03 and release on 2024-09-10).

@HarHarLinks HarHarLinks marked this pull request as ready for review August 30, 2024 15:16
@HarHarLinks HarHarLinks requested a review from a team as a code owner August 30, 2024 15:16
@HarHarLinks HarHarLinks force-pushed the nic/feat/NEO-721-downlad-file-api branch from d3462dd to d325f55 Compare August 30, 2024 15:17
@HarHarLinks
Copy link
Contributor

one missing part appears

diff --git a/example-widget-mui/src/ImagePage/ImagePage.test.tsx b/example-widget-mui/src/ImagePage/ImagePage.test.tsx
index 69233d9..9842b7a 100644
--- a/example-widget-mui/src/ImagePage/ImagePage.test.tsx
+++ b/example-widget-mui/src/ImagePage/ImagePage.test.tsx
@@ -95,6 +95,7 @@ describe('<ImagePage>', () => {
         ROOM_EVENT_UPLOADED_IMAGE,
       ),
       WidgetApiFromWidgetAction.MSC4039UploadFileAction,
+      WidgetApiFromWidgetAction.MSC4039DownloadFileAction,
       WidgetApiFromWidgetAction.MSC4039GetMediaConfigAction,
     ]);

Copy link
Contributor

@mgcm mgcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@HarHarLinks HarHarLinks merged commit 9852f94 into main Sep 4, 2024
4 checks passed
@HarHarLinks HarHarLinks deleted the nic/feat/NEO-721-downlad-file-api branch September 4, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants