Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition in txConns #51

Merged
merged 1 commit into from
May 25, 2020
Merged

fix: race condition in txConns #51

merged 1 commit into from
May 25, 2020

Conversation

teckick
Copy link
Member

@teckick teckick commented May 17, 2020

use txConns in Executor without locking can cause race condition, which leads to gaea-proxy panic (#50)

fix this problem by adding lock to txConns.

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #51 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   53.68%   53.66%   -0.03%     
==========================================
  Files         135      135              
  Lines       25983    25993      +10     
==========================================
  Hits        13949    13949              
- Misses      11060    11070      +10     
  Partials      974      974              
Flag Coverage Δ
#unittests 53.66% <0.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
proxy/server/executor.go 1.34% <0.00%> (-0.03%) ⬇️
proxy/server/executor_handle.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60dcdf0...1b35d4d. Read the comment docs.

Copy link
Contributor

@chicliz chicliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teckick teckick merged commit bac58f4 into nooncall:master May 25, 2020
@teckick teckick deleted the fix-race-condition-in-txConns branch June 1, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants