Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dashboard welcomes user by their name #375

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Conversation

dickeyy
Copy link
Contributor

@dickeyy dickeyy commented Jul 31, 2024

Fixes: #372

Proposed Changes

  • Change the dashboard welcome message from "Good Afternoon, Ahmed!" to "Good Afternoon, {user}!"
  • Checks if user.firstName exists otherwise it uses user.emailAddresses[0].emailAddress.split("@")[0].split(".")

Ex:
image

Copy link

vercel bot commented Jul 31, 2024

@dickeyy is attempting to deploy a commit to the Noodle Team on Vercel.

A member of the Team first needs to authorize it.

@dickeyy dickeyy requested a review from ixahmedxi August 4, 2024 19:08
Copy link
Collaborator

@ixahmedxi ixahmedxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great!

@ixahmedxi ixahmedxi merged commit ef43f41 into noodle-run:main Aug 10, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add actual users name / email to dashboard welcome message
3 participants