Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs | Bucket Types #1448

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

Neon-White
Copy link
Contributor

@Neon-White Neon-White commented Sep 27, 2024

Explain the changes

  1. Add documentation regarding NooBaa bucket types

@Neon-White Neon-White added the documentation Improvements or additions to documentation label Sep 27, 2024
@Neon-White Neon-White marked this pull request as draft September 27, 2024 13:40
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 11, 2024
@Neon-White Neon-White marked this pull request as ready for review November 13, 2024 11:01
doc/bucket-types.md Outdated Show resolved Hide resolved
@@ -0,0 +1,35 @@
[NooBaa Operator](../README.md) /

# Bucket Types in NooBaa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is great contribution, and I think it can be even better in noobaa-core

doc/bucket-types.md Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
@Neon-White Neon-White mentioned this pull request Nov 25, 2024
1 task
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
doc/bucket-types.md Outdated Show resolved Hide resolved
@shirady
Copy link
Contributor

shirady commented Nov 27, 2024

@Neon-White @romayalon - what did you decide about this doc (see comment) - in the operator or core repo?
I think it is good and can approve it...

@Neon-White
Copy link
Contributor Author

Continued in noobaa/noobaa-core#8568

@Neon-White Neon-White closed this Dec 2, 2024
@Neon-White Neon-White deleted the docs-bucket-types branch December 2, 2024 13:59
@Neon-White Neon-White restored the docs-bucket-types branch December 2, 2024 17:00
@Neon-White
Copy link
Contributor Author

After reconsidering, moving this to the core has crept outside the scope of the original task; and thus I'm reopening the original PR

Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neon-White Neon-White merged commit d656204 into noobaa:master Dec 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants