Added a CLI sub-command in noobaa diagnostics to print proxy details #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
requested review from
Neon-White,
jackyalbo,
liranmauda and
shirady
achouhan09
force-pushed
the
diagnostics
branch
from
6047c1f to
0b170a6
Compare
shirady
reviewed
Sep 15, 2024
achouhan09
force-pushed
the
diagnostics
branch
from
0b170a6 to
e3d8c7b
Compare
liranmauda
requested changes
Sep 17, 2024
pkg/diagnostics/diagnostics.go
Outdated
| func CmdReport() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "report", | ||
| Short: "Reports the proxy status", |
There was a problem hiding this comment.
The command will not only run a report of the proxy, but it will be extended to other issues as well.
Suggested change
| Short: "Reports the proxy status", | |
| Short: "Run reports of the status and setup", |
Neon-White
approved these changes
Sep 17, 2024
liranmauda
approved these changes
Sep 17, 2024
Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
diagnostics
branch
from
a25496b to
46c85f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
The CLI command checks and logs the values of essential environment variables related to proxy configuration (HTTP_PROXY, HTTPS_PROXY, NO_PROXY). It performs the following actions:
Checks: Verifies if these proxy environment variables are set and not empty.
This implementation currently focuses on proxy environment variables but is designed with future expansion in mind. Additional checks and diagnostics will be introduced in the future.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
noobaa diagnostics reportto check the proxy status.Note: Use the command
kubectl set env deployment/noobaa-operator -c noobaa-operator HTTP_PROXY=localhost:8080to update the proxy vars.