-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Default Backingstore for AWS STS with CCO #1253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detailed Testing Instructions:Using AWS cluster with cluster-botThose are informal testing instructions until we have an AWS STS cluster.
Additional instructions for MacOS users:In the instruction there is a use of a tool
Images for cluster-bot:I have MacOS, for using the cluster-bot I need the operator image for linux/amd64. Noobaa Operator repository:
Noobaa Core repository:
|
This was referenced Nov 28, 2023
dannyzaken
reviewed
Dec 3, 2023
shirady
force-pushed
the
sts-cco-default-bs
branch
from
December 4, 2023 09:42
1436c31
to
5ae7167
Compare
dannyzaken
approved these changes
Dec 4, 2023
1. Edit the volumeMount and volume to the operator deployment so that the operator can assume the role with web identity. 2. Add annotation to the CSV to claim support for STS 3. Get ROLEARN and web identitiy token path to the credentials request for the CCO (cloud credential operator). - Get the role ARN from the environment variable set on the pod by the subscription config and set the webIdentityTokenPath as const - Add the role ARN and web identity token path to the credentials request and apply it during operator initialization. 4. Add the option aws-sts-arn to pass the role arn (for testing) Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
sts-cco-default-bs
branch
from
December 5, 2023 06:21
5ae7167
to
3c9369c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
volumeMount
andvolume
to the operator deployment, endpoint deployment, and statefulset noobaa-core so they can assume the role with web identity.volumeMounts
twice, so I removed the second time it appeared and moved the key-values that we had there using the conventionname
and thenmountPath
.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
aws-s3
withawsSTSRoleARN
value in Phase Ready (more details for developers in the comment below).