Adding operator checks for External DB w/o SSL #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyalbo
changed the title
liranmauda
reviewed
Sep 21, 2023
liranmauda
reviewed
Sep 21, 2023
| db_url, err)) | ||
| } | ||
| // Check if the version is 15 | ||
| if version != "15" { |
There was a problem hiding this comment.
Why do we want to limit it only to this specific version?
Can we use a min version (maybe 12?)
There was a problem hiding this comment.
We want to support just specific versions that we know we support and work well with noobaa. We can maybe add 12 (and only 12) but as we are going forward we probably decide not to... anyway an easy fix if we want to support more versions.
liranmauda
approved these changes
Sep 21, 2023
jackyalbo
force-pushed
the
jacky-external-db
branch
2 times, most recently
from
4706c54 to
eb0a638
Compare
adding external ssl validator using pq driver for golang fix - adapting secret to the one in noobaa spec Signed-off-by: jackyalbo <[email protected]>
jackyalbo
force-pushed
the
jacky-external-db
branch
from
eb0a638 to
72bc5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: