Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SSL support to External Postgres #1216

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Sep 14, 2023

Explain the changes

Commit 1:

  1. Adding support to SSL with external postgres DB both for server side (ssl-required will validate the certificate of the server), and also for client side (user can use ssl-key and ssl-cert to connect with the server)

Commit 2:

  1. Adding an options to run noobaa install with ssl options (both sides)
  2. Adding the options to run test-cli with --dev option to make it possible to run on M1 macs

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo marked this pull request as draft September 14, 2023 12:00
@liranmauda liranmauda self-requested a review September 18, 2023 10:33
@jackyalbo jackyalbo marked this pull request as ready for review September 18, 2023 10:36
pkg/apis/noobaa/v1alpha1/noobaa_types.go Outdated Show resolved Hide resolved
pkg/options/options.go Outdated Show resolved Hide resolved
pkg/options/options.go Outdated Show resolved Hide resolved
@jackyalbo jackyalbo merged commit ca77862 into noobaa:master Sep 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants