Skip to content

Commit

Permalink
Merge pull request #1464 from liranmauda/liran-ci-linter
Browse files Browse the repository at this point in the history
Removing golangci-lint-action in favor or make lint
  • Loading branch information
liranmauda authored Oct 27, 2024
2 parents c611e73 + 88564d2 commit cc33bce
Showing 1 changed file with 5 additions and 16 deletions.
21 changes: 5 additions & 16 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,9 @@ jobs:
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
- uses: actions/setup-go@v5
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.55

# Optional: if set to true then the all caching functionality will be complete disabled,
# takes precedence over all other caching options.
# skip-cache: true

# Optional: working directory, useful for monorepos
# working-directory: somedir

# Optional: golangci-lint command line arguments.
args: --disable-all --print-issued-lines -E typecheck,errcheck,gosimple,unused,ineffassign,staticcheck --timeout=4m
# Optional: show only new issues if it's a pull request. The default value is `false`.
# only-new-issues: true
go-version: "1.21"
- name: run lint
id: run-build
run: make lint || exit 1

0 comments on commit cc33bce

Please sign in to comment.