Skip to content

Commit

Permalink
bucket notification - check pvcName, not pvc DFBUGS 988, 991 (#1485)
Browse files Browse the repository at this point in the history
Signed-off-by: Amit Prinz Setter <[email protected]>
  • Loading branch information
alphaprinz authored Dec 10, 2024
1 parent e2ea947 commit 88aef43
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/system/phase2_creating.go
Original file line number Diff line number Diff line change
Expand Up @@ -1242,15 +1242,15 @@ func (r *Reconciler) ReconcileODFPersistentLoggingPVC(
log := r.Logger.WithField("func", "ReconcileODFPersistentLoggingPVC")

// Return if persistent logging PVC already exists
if pvc != nil {
if pvcName != nil {
pvc.Name = *pvcName;
log.Infof("PersistentLoggingPVC %s already exists and supports RWX access mode. Skipping ReconcileODFPersistentLoggingPVC.", *pvcName)
return nil
}

util.KubeCheck(pvc)
if pvc.UID != "" {
log.Infof("Persistent logging PVC %s already exists. Skipping creation.", *pvcName )
log.Infof("Persistent logging PVC %s already exists. Skipping creation.", pvc.Name)
return nil
}

Expand All @@ -1259,7 +1259,7 @@ func (r *Reconciler) ReconcileODFPersistentLoggingPVC(
}
r.Own(pvc);

log.Infof("Persistent logging PVC %s does not exist. Creating...", *pvcName)
log.Infof("Persistent logging PVC %s does not exist. Creating...", pvc.Name)
err := r.Client.Create(r.Ctx, pvc)
if err != nil {
return err
Expand Down

0 comments on commit 88aef43

Please sign in to comment.