Backport to 5.18 #8704
Merged
Backport to 5.18 #8704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we exceed the object quota for a bucket, we should provide an error message which can convey the clear problem. https://issues.redhat.com/browse/DFBUGS-242 Signed-off-by: Ashish Pandey <[email protected]> (cherry picked from commit dd93e63)
1. In config.js move the definition of ACCOUNTS_ID_CACHE_EXPIRY near the the configurations of OBJECT_SDK_BUCKET_CACHE_EXPIRY_MS and OBJECT_SDK_ACCOUNT_CACHE_EXPIRY_MS. 2. In accountspace_fs.js: - Remove the Number conversion as the value is number (was Number(config.ACCOUNTS_ID_CACHE_EXPIRY)). - Change the JSDoc of params so it will be easier to read. - Change the load inside function to be get_identity_by_id_and_stat_file so we will have the identity with the stat as property inside it. - Add the validate method, and add the functions _validate_account_id and check_same_stat_account that were partially copied from object_sdk. 3. In config_fs add the function get_identity_by_id_and_stat_file and stat_account_config_file_by_identity that would try to stat the account config file (covering the identity, accounts_by_name - new path, accounts - old path). 4. In object_sdk.js add a new line between anonymous_access_key bucket_namespace_cache for easier readability, fix a typo in a comment. Signed-off-by: shirady <[email protected]> (cherry picked from commit 12c6d90)
Signed-off-by: Aayush Chouhan <[email protected]> (cherry picked from commit 7802f6f)
1. Change the condition in rest_s3 and bucketspace_fs to check the permission by the principal on account name when the previous check was only not DENY,
so in case someone puts several statements using both account ID and account name, we won't skip it after the checks on the account ID.
2. Add logs in level 3 to help investigate bucket policy issues.
Signed-off-by: shirady <[email protected]>
(cherry picked from commit c096f08)
… to both Containerized and NC environments Signed-off-by: Romy <[email protected]> (cherry picked from commit 321d8b4)
…tests Signed-off-by: Romy <[email protected]> CR Signed-off-by: Romy <[email protected]> (cherry picked from commit 19a16d6)
Signed-off-by: Romy <[email protected]> (cherry picked from commit 70d7d56)
Signed-off-by: naveenpaul1 <[email protected]> (cherry picked from commit 12d9107)
- Correct minor problems in the AWS API compatibility doc Signed-off-by: Ben <[email protected]> (cherry picked from commit d8a0c65)
Signed-off-by: Romy <[email protected]> (cherry picked from commit 3eca5c4)
romayalon
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes