Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket notifications - validate notifications on change (gh issue 8649) #8667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bucket notifications - validate notifications on change (gh issue 8649) #8667

wants to merge 1 commit into from

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. As per aws spec, when bucket's notification change, all of the bucket's notification configuration are validated.
    If one of them fails, the user's request is failed.

Issues: Fixed #xxx / Gap #xxx

  1. put-bucket notification should check the connection before saving the information to the bucket #8649

Testing Instructions:

  1. Create a new bucket with a non-existing connect file or with a wrong connect info.
  2. Bucket creation should fail.
  • Doc added/updated
  • Tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon Awaiting requested review from romayalon

@shirady shirady Awaiting requested review from shirady

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alphaprinz