NC | Online Upgrade | Tests | Config directory restructure upgrade script unit tests

[romayalon]

Explain the changes

1. Added unit tests for every function in noobaa-core/src/upgrade/nc_upgrade_scripts/1.0.0/config_dir_restructure.js.
2. config dir restructure -

• did some small refactoring
• added handling in removing name symlink in case the new symlink /etc/noobaa.conf.d/accounts_by_name/account1.symlink points to a wrong/non existing location and then re-creating the link correctly, added also the matching tests for this case - notice this is an artificial test and is not suppose to happen in the usual flow.
  The relevant tests for this case -

1. create_account_name_index_if_missing() - new name index already exists and points to wrong location
2. create_account_access_keys_index_if_missing() - new access key index already exists and points to a wrong location
3. create_account_name_index_if_missing() - new name index already exists and points to a non existing location
4. create_account_access_keys_index_if_missing() - new access key index already exists and points to a non existing location

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

1. sudo jest --testRegex=jest_tests/test_config_dir_restructure_upgrade_script.test.js

• Doc added/updated
• Tests added

[shirady]

@romayalon could you update the doc file of CI&Tests.md with the new tests files?

[shirady]

LGTM
I added additional small comments