NC | Online Upgrade | Add nc_upgrade_manager.upgrade_config_dir() unit tests #8645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
reviewed
Jan 6, 2025
|
@romayalon could you edit the PR description and use the exact function ( |
romayalon
changed the title
romayalon
force-pushed
the
romy-add-config-dir-upgrade-tests
branch
from
a20a9a9 to
faf4d5f
Compare
romayalon
force-pushed
the
romy-add-config-dir-upgrade-tests
branch
from
faf4d5f to
f9912a2
Compare
shirady
reviewed
Jan 7, 2025
romayalon
force-pushed
the
romy-add-config-dir-upgrade-tests
branch
from
f9912a2 to
0690d59
Compare
Signed-off-by: Romy <[email protected]>
romayalon
force-pushed
the
romy-add-config-dir-upgrade-tests
branch
from
0690d59 to
e20c6e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo jest --testRegex=jest_tests/test_nc_upgrade_manager.test.js --t "nc upgrade manager - upgrade_config_dir"