Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for not accepting the past dates as expiration for bucket lifecycle rules #8633

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for not accepting the past dates as expiration for bucket lifecycle rules #8633

wants to merge 2 commits into from
+48 −1

Conversation

achouhan09
Copy link
Member

@achouhan09 achouhan09 commented Dec 27, 2024 •
edited
Loading

Explain the changes

  1. Added a fix for not accepting past dates as expiration for bucket lifecycle rules also will reject if expiration date is not in correct format.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed: NSFS | S3 | Lifecycle: Expiration Date in the past gets accepted #8551

Testing Instructions:

  • Tests added

@achouhan09 achouhan09 requested review from liranmauda, shirady, naveenpaul1, a team and Neon-White and removed request for a team December 27, 2024 15:09
@achouhan09 achouhan09 requested a review from romayalon December 30, 2024 12:05
@achouhan09 achouhan09 changed the title NSFS | Fix for not accepting the past dates as expiration for bucket lifecycle rules Fix for not accepting the past dates as expiration for bucket lifecycle rules Dec 30, 2024
@romayalon
Copy link
Contributor

Hey @achouhan09

  1. Can you please link to the Issues section the bug you are fixing?
  2. Please add tests

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 2, 2025
@achouhan09
Copy link
Member Author

Hi @romayalon
Added issue link and tests. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda Awaiting requested review from liranmauda

@shirady shirady Awaiting requested review from shirady

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

@Neon-White Neon-White Awaiting requested review from Neon-White Neon-White was automatically assigned from noobaa/dev

@romayalon romayalon Awaiting requested review from romayalon

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS | S3 | Lifecycle: Expiration Date in the past gets accepted
2 participants
@achouhan09 @romayalon