Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on TypeScript 5.5.2 #159

Closed
DiFuks opened this issue Jun 20, 2024 · 1 comment · Fixed by #161, samchon/typia#1129 or samchon/nestia#935
Closed

Not working on TypeScript 5.5.2 #159

DiFuks opened this issue Jun 20, 2024 · 1 comment · Fixed by #161, samchon/typia#1129 or samchon/nestia#935

Comments

@DiFuks
Copy link
Contributor

DiFuks commented Jun 20, 2024

Branch for reproduction: https://github.com/DiFuks/ts-overrides-plugin/tree/ts-5.5.2

GHA: https://github.com/DiFuks/ts-overrides-plugin/actions/runs/9603473575/job/26486752499

However, with version 5.5.1-rc, this problem does not occur, and the plugin works perfectly. GHA: https://github.com/DiFuks/ts-overrides-plugin/actions/runs/9603497686/job/26486838709

Difference between branches: DiFuks/ts-overrides-plugin@ts-5.5.2...ts-5.5.1-rc

@osyrisrblx
Copy link
Contributor

Looks like the regex against lib/typescript.js is failing.

5.5.1-rc

// ...
});
})(typeof module !== "undefined" && module.exports ? module : { exports: ts });
if (typeof module !== "undefined" && module.exports) { ts = module.exports; }
//# sourceMappingURL=typescript.js.map

5.5.2

// ...
});
})({ get exports() { return ts; }, set exports(v) { ts = v; if (typeof module !== "undefined" && module.exports) { module.exports = v; } } })
//# sourceMappingURL=typescript.js.map

samchon added a commit to samchon/typia that referenced this issue Jun 21, 2024
As TypeScript v5.5.2 suddenly had taken a break change on its compiler soure code, `ts-patch` has failed to patch transformation to the TypeScript v5.5.2 compiler.

Therefore, block the TypeScript v5.5 through `peerDependencies` untill `nonara` fixes the nonara/ts-patch#159 problem.
samchon added a commit to samchon/tgrid that referenced this issue Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants