Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .json() to strings module #237

Closed
vdrg opened this issue Nov 28, 2023 · 2 comments
Closed

Add .json() to strings module #237

vdrg opened this issue Nov 28, 2023 · 2 comments

Comments

@vdrg
Copy link
Contributor

vdrg commented Nov 28, 2023

We could add a .json or .toJson function to the strings module, which is simpler than having to do json.create(val) (these functions should also return a JsonResult).
@gnkz
Copy link
Contributor

gnkz commented Nov 29, 2023

what about parseJson? This would be in line with the other methods that parse string values to other types

@vdrg
Copy link
Contributor Author

vdrg commented Nov 29, 2023

Works too

gnkz added a commit that referenced this issue Nov 29, 2023
@gnkz
feat: string to json
47a67e7 
Solves #237
@gnkz gnkz mentioned this issue Nov 29, 2023
Merged
gnkz added a commit that referenced this issue Nov 29, 2023
@gnkz
feat: string to json (#238)
f67740f 
* feat: string to json

Solves #237

* docs: update strings references
@gnkz gnkz closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vdrg @gnkz