fix(core): centerInsuffientSlides takes offsets into account #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
t0ggles-create swiper |
|
Task nolimits4web/SWIPER-86 was created |
|
Hi @nolimits4web, I also ran into this problem. Any chance to get this released in the next few weeks? @slemling Thanks for the fix. This saves me from building a messy workaround. |
|
Hey, any update here? It would be great to get a fix some time soon :) |
|
Task nolimits4web/SWIPER-86 status changed to Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using centerInsufficientSlides together with slidesOffsetBefore and slidesOffsetAfter, the slides won’t be centered correctly. Apparently slidesOffsetBefore and slidesOffsetAfter are not taken into account in the calculation of the offset for centerInsufficientSlides.
Codesandbox
Resolves #5436 (was closed already due to lacking information / activity, but issue still remains)