Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed can not get clicked slider in shadow root issue #5223

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Fixed can not get clicked slider in shadow root issue #5223

merged 2 commits into from
Nov 24, 2021

Conversation

yaoguoba
Copy link
Contributor

Fixed can not get clicked slider in shadow root issue

@yaoguoba yaoguoba closed this Nov 23, 2021
@yaoguoba yaoguoba reopened this Nov 23, 2021
@yaoguoba
Copy link
Contributor Author

yaoguoba commented Nov 23, 2021

#5221

@nolimits4web
Copy link
Owner

  • event.path is not standard property
  • I guess e.path[0] you pass to updateClickedSlide is an Element, so accessing e.target in updateClickedSlide will be anyway undefined

@yaoguoba
Copy link
Contributor Author

Sorry, I forgot to change updateClickedSlide.
Do you mean we can't use e.path here, I saw e.path used in onTouchStart.

Anyway, I will check the other way and will update later.

@yaoguoba
Copy link
Contributor Author

Hi @nolimits4web,

Event.composedPath is a standard equivalent which is a method.
Please check.

@nolimits4web nolimits4web merged commit 3caf40d into nolimits4web:master Nov 24, 2021
@nolimits4web
Copy link
Owner

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants