Fix createIndex doesn't "do nothing" (#228)

* Add test for broken createIndex * Fix createIndex updating revision
nolanlawson · Nov 16, 2016 · e60b1e5 · e60b1e5
1 parent 1b7c92b
commit e60b1e5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/lib/adapters/local/create-index/index.js b/lib/adapters/local/create-index/index.js
@@ -40,6 +40,10 @@ function createIndex(db, requestDef) {
 
     viewExists = !!doc.views[viewName];
 
+    if (viewExists) {
+      return false;
+    }
+
     doc.views[viewName] = {
       map: {
         fields: utils.mergeObjects(requestDef.index.fields)

diff --git a/test/test-suite-1/test.basic.js b/test/test-suite-1/test.basic.js
@@ -29,6 +29,32 @@ module.exports = function (dbType, context) {
       });
     });
 
+    it('should not update an existing index', function () {
+      var db = context.db;
+      var index = {
+        "index": {
+          "fields": ["foo"]
+        },
+        "name": "foo-index",
+        "type": "json"
+      };
+      return db.createIndex(index).then(function (response) {
+        response.id.should.match(/^_design\//);
+        response.name.should.equal('foo-index');
+        response.result.should.equal('created');
+        return db.createIndex(index);
+      }).then(function (response) {
+        response.id.should.match(/^_design\//);
+        response.name.should.equal('foo-index');
+        response.result.should.equal('exists');
+        return response.id;
+      }).then(function (ddocId) {
+        return db.get(ddocId);
+      }).then(function (doc) {
+        doc._rev.slice(0, 1).should.equal('1');
+      });
+    });
+
     it('throws an error for an invalid index creation', function () {
       var db = context.db;
       return db.createIndex('yo yo yo').then(function () {