-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update svelte to 3.37.0 #152
Conversation
Hm, this causes a memory leak because disconnecting the custom element no longer destroys the Svelte component, which means that the ResizeObserver action's |
Realized tests for old Svelte probably aren't possible. I think since I'm not going to make Svelte a peerDependency I should just add a note to the readme that if you're using |
The failed test in Svelte 3.38.0 is due to changing the order of items in a keyed each block, so it looks like the same issue as sveltejs/svelte#6444 Svelte 3.38.0 also seems to increase the code side a fair amount, apparently due to hydration code being added, even though the component is not hydratable. Seems due to: sveltejs/svelte@10e3e3d |
I filed a bug about the size increase: sveltejs/svelte#6462 Due to that and the keyed each bug, we'll probably want to hold off on updating to Svelte 3.38.0+ for now. |
288d8e0
to
131c606
Compare
Incidentally this fixes #149.
TODO: