Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom-elements.json #142

Merged
merged 4 commits into from
Jun 26, 2021
Merged

feat: add custom-elements.json #142

merged 4 commits into from
Jun 26, 2021

Conversation

nolanlawson
Copy link
Owner

Fixes #31

I think this is mostly aspirational, as it doesn't seem like this file format is supported out-of-the-box by VS Code or WebStorm, but this post convinced me to go ahead and add it. Maybe it will do something useful in the future!

If nothing else, if IDEs ever add support for this and I did something wrong, at least there is a file now that people can edit and open a PR to fix.

@nolanlawson
Copy link
Owner Author

nolanlawson commented Jun 26, 2021

I can't seem to get this to work in VS Code or in WebStorm, and the <api-viewer> element doesn't support the 1.0.0 format yet (open-wc/api-viewer-element#61), and even when I run a basic element through @custom-elements-manifest/analyzer, the output doesn't perfectly agree with the TypeScript definition from @webcomponents / custom-elements-manifest (it says tagName does not exist on ClassDeclaration).

So it really feels like early days for this, but it's a great idea, so I'll add it anyway.

@nolanlawson
Copy link
Owner Author

Reported the bug about tagName. Keeping it for now because it might be an issue in the spec, not the analyzer? open-wc/custom-elements-manifest#43

@nolanlawson nolanlawson merged commit fd3e0f3 into master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom-elements.json
1 participant